commit e18fc03c5e8ee4641c1a8c1d52f1cfd0de1db33f
from: Martijn van Duren <martijn@openbsd.org>
date: Fri Dec 19 10:24:02 2025 UTC

Somewhere down the line the arguments of auth result and auth username
must have been flipped.

commit - e30dd6929ed750a3228af965628c6bf9ff4bc357
commit + e18fc03c5e8ee4641c1a8c1d52f1cfd0de1db33f
blob - a1e0cfb4a13324f479e90d29462ef19121fa7a44
blob + de424d94d67933c729af997bcd307553eccd3009
--- opensmtpd.c
+++ opensmtpd.c
@@ -1490,16 +1490,16 @@ osmtpd_link_tls(struct osmtpd_callback *cb, struct osm
 
 static void
 osmtpd_link_auth(struct osmtpd_callback *cb, struct osmtpd_session *session,
-    char *username, char *linedup)
+    char *status, char *linedup)
 {
 	int (*f)(struct osmtpd_ctx *, const char *, enum osmtpd_auth_status);
-	char *status;
+	char *username;
 	enum osmtpd_auth_status s;
 
-	if ((status = strrchr(username, '|')) == NULL)
+	if ((username = strrchr(status, '|')) == NULL)
 		osmtpd_errx(1, "Invalid auth received: %s", linedup);
-	status[0] = '\0';
-	status++;
+	username[0] = '\0';
+	username++;
 	if (strcmp(status, "pass") == 0)
 		s = OSMTPD_AUTH_PASS;
 	else if (strcmp(status, "fail") == 0)