Commit Diff

Commit:
76b35bc9c1cee9c4e28614b93b1221912dfbbe1c
From:
Martijn van Duren <martijn@openbsd.org>
Date:
Message:
Do proper return value checking around close.
Actions:
Patch | Tree
commit - 332482f3bb9cf9a11810bac44d94d2170400cf2e
commit + 76b35bc9c1cee9c4e28614b93b1221912dfbbe1c
blob - 376fcdbc2dd6ef4eed6964cab070f04ec67da69e
blob + 9ff93b57aababbca8394d8ef3233be131dee0f48
--- vias.c
+++ vias.c
@@ -197,6 +197,7 @@ permit(uid_t uid, gid_t *groups, int ngroups, struct r
 {
 	int i;
 	int fd = -1, pfd = -1;
+	int serrno
 	uid_t suid = -1;
 	struct rule *r;
 	char *rfile;
@@ -229,7 +230,8 @@ permit(uid_t uid, gid_t *groups, int ngroups, struct r
 		}
 	}
 	if (*lastr == NULL || (*lastr)->action != PERMIT) {
-		close(fd);
+		if (close(fd) == -1)
+			err(1, "close");
 		return -1;
 	}